Skip to content

signer/core/apitypes: fix issue in complex typed data signing#24220

Merged
holiman merged 1 commit into
ethereum:masterfrom
holiman:fix_712
Feb 8, 2022
Merged

signer/core/apitypes: fix issue in complex typed data signing#24220
holiman merged 1 commit into
ethereum:masterfrom
holiman:fix_712

Conversation

@holiman
Copy link
Copy Markdown
Contributor

@holiman holiman commented Jan 10, 2022

This is a rebased version of #24102.
Looks good to me (I'm not the author)

@fjl fjl changed the title signer/core: fix complex typed data signing (EIP-712) signer/core/apitypes: fix issue in complex typed data signing Feb 8, 2022
@holiman holiman self-assigned this Feb 8, 2022
@pranksteess
Copy link
Copy Markdown
Contributor

Thanks, let's do it

@holiman
Copy link
Copy Markdown
Contributor Author

holiman commented Feb 8, 2022

@fjl rebased, can you please 👍 ?

@holiman holiman added this to the 1.10.16 milestone Feb 8, 2022
@holiman holiman merged commit 5a0d487 into ethereum:master Feb 8, 2022
@holiman holiman deleted the fix_712 branch February 8, 2022 13:40
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Feb 11, 2022
Co-authored-by: specerxi <xhxpecer@gmail.com>
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Co-authored-by: specerxi <xhxpecer@gmail.com>
and00999 pushed a commit to and00999/go-ethereum that referenced this pull request Jul 7, 2022
MariusVanDerWijden pushed a commit to MariusVanDerWijden/go-ethereum that referenced this pull request Feb 2, 2026
Co-authored-by: specerxi <xhxpecer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants